mmalffmpeg: Add lock on buffer release and log message #9973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an occasional crash with software decode in AllocateBuffer near end of file that appears to be due to the missing lock in ReleaseBuffer function. Also add a debug message for the (unusual) case of a buffer being freed due to a change in resolution of the stream.
|
jenkins build this please |
1 similar comment
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an occasional crash with software decode in
AllocateBuffer near end of file that appears to be due to
the missing lock in ReleaseBuffer function.
Also add a debug message for the (unusual) case of a buffer
being freed due to a change in resolution of the stream.