Skip to content

Commit

Permalink
Fixes
Browse files Browse the repository at this point in the history
Signed-off-by: Eugene Bolshakov <pub@relvarsoft.com>
  • Loading branch information
xbolshe committed Feb 11, 2018
1 parent 032071b commit ee40cbc
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 23 deletions.
16 changes: 8 additions & 8 deletions packages/rocketchat-api/server/v1/channels.js
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ RocketChat.API.v1.addRoute('channels.counters', { authRequired: true }, {
let msgs = null;
let latest = null;
let members = null;

if (ruserId) {
if (!access) {
return RocketChat.API.v1.unauthorized();
Expand All @@ -172,13 +172,13 @@ RocketChat.API.v1.addRoute('channels.counters', { authRequired: true }, {
}

return RocketChat.API.v1.success({
joined: joined,
members: members,
unreads: unreads,
unreadsFrom: unreadsFrom,
msgs: msgs,
latest: latest,
userMentions: userMentions
joined,
members,
unreads,
unreadsFrom,
msgs,
latest,
userMentions
});
}
});
Expand Down
19 changes: 11 additions & 8 deletions packages/rocketchat-api/server/v1/groups.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,9 @@ RocketChat.API.v1.addRoute('groups.counters', { authRequired: true }, {
let userMentions = null;
let unreadsFrom = null;
let joined = false;
let msgs = null;
let latest = null;
let members = null;

if ((!params.roomId || !params.roomId.trim()) && (!params.roomName || !params.roomName.trim())) {
throw new Meteor.Error('error-room-param-not-provided', 'The parameter "roomId" or "roomName" is required');
Expand Down Expand Up @@ -150,21 +153,21 @@ RocketChat.API.v1.addRoute('groups.counters', { authRequired: true }, {
unreadsFrom = group.ls;
joined = true;
}

if (access || joined) {
msgs = room.msgs;
latest = room.lm;
members = room.usernames.length;
}

return RocketChat.API.v1.success({
joined: joined,
members: members,
unreads: unreads,
unreadsFrom: unreadsFrom,
msgs: msgs,
latest: latest,
userMentions: userMentions
joined,
members,
unreads,
unreadsFrom,
msgs,
latest,
userMentions
});
}
});
Expand Down
14 changes: 7 additions & 7 deletions packages/rocketchat-api/server/v1/im.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,13 @@ RocketChat.API.v1.addRoute(['dm.counters', 'im.counters'], { authRequired: true
}

return RocketChat.API.v1.success({
joined: joined,
members: members,
unreads: unreads,
unreadsFrom: unreadsFrom,
msgs: msgs,
latest: latest,
userMentions: userMentions
joined,
members,
unreads,
unreadsFrom,
msgs,
latest,
userMentions
});
}
});
Expand Down

0 comments on commit ee40cbc

Please sign in to comment.