Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MD5 algorithm fixed-output derivations broken by nixpkgs: #2

Closed
considerate opened this issue Oct 29, 2023 · 1 comment
Closed

MD5 algorithm fixed-output derivations broken by nixpkgs: #2

considerate opened this issue Oct 29, 2023 · 1 comment

Comments

@considerate
Copy link
Contributor

Nixpkgs now throws errors when outputHashAlgo is "md5" this means that stdenv.mkDerivation cannot be used in dvc.nix because of the insecurity of the MD5 hash algorithm. I think a short-term solution would be to create a derivation without going through stdenv.mkDerivation.

It seems that DVC might go with blake3 as their next hashing algorithm:

iterative/dvc#3069

However, nix still doesn't support blake3 as the algorithm:

NixOS/nix#8475

Thus, I think we need to continue supporting MD5 for the time being, despite nixpkgs dropping support for it.

@considerate
Copy link
Contributor Author

Closed in #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant