Refine test case: nodeset_cmdline, nodeset_runimage, nodeset_shell #3266
Conversation
| @@ -71,7 +70,8 @@ BEGIN | |||
| print "$::USAGE"; | |||
| exit 1; | |||
| } | |||
| my $os = xCAT::Utils->osver("all"); | |||
| my $os = &get_os; | |||
| print "os is $os\n"; | |||
There was a problem hiding this comment.
What is principle of when using print, when using send_msg?
| @@ -264,7 +266,7 @@ sub testxdsh { | |||
| if (($value == 1) || ($value == 2) || ($value == 3)) { | |||
| `xdsh $noderange -t 2 cat $checkfile |grep $checkstring`; | |||
| if ($?) { | |||
| foreach (1 .. 1500) { | |||
There was a problem hiding this comment.
@zet809 I debug the code so change to 15 and will change to 1500
| @@ -236,6 +237,7 @@ sub rungenesisimg { | |||
| chmod 0755, "/install/my_image/runme.sh"; | |||
| `tar -zcvf /tmp/my_image.tgz -C /install/my_image .`; | |||
| copy("/tmp/my_image.tgz", "/install/my_image") or die "Copy failed: $!"; | |||
| print "master is $master\n"; | |||
There was a problem hiding this comment.
@zet809 yes for debug and will send out message during run testcases
| @@ -5,7 +5,6 @@ BEGIN | |||
| $::XCATROOT = $ENV{'XCATROOT'} ? $ENV{'XCATROOT'} : -d '/opt/xcat' ? '/opt/xcat' : '/usr'; | |||
There was a problem hiding this comment.
The line 5 and 7 shall also be removed.
|
Looks good to me. |
|
The testcase:added label in my opinion should be used to track issues that have slipped through regression, we should not use for pull requests. If an issue is opened that slipped through regression testing, we would tag the "testcase:requested" label, then when a pull request is created to add a testcase, we would change "requested" -> "added" and then when we search "testcase:requested" it no longer is needed. |
|
Hi, @junxiawang , the pull request looks good to me. But #2833 is used to fix #2442 and #1871, why this duplicated task created? |
| @@ -2,7 +2,7 @@ start:nodeset_shell | |||
| description: verify could log in genesis shell | |||
| cmd:perl /opt/xcat/share/xcat/tools/autotest/testcase/genesis/genesistest.pl -n $$CN -g | |||
| check:rc==0 | |||
| cmd:perl /opt/xcat/share/xcat/tools/autotest/testcase/genesis/genesistest.pl -n $$CN -s | |||
| cmd:perl /opt/xcat/share/xcat/tools/autotest/testcase/genesis/genesistest.pl -n $$CN -s ;if [[ $? -eq 0 ]];then exit 0 ;else cat /var/log/consoles/$$CN; cat /tmp/genesistestlog/*;exit 1;fi | |||
There was a problem hiding this comment.
The console log is very big, include some specific character, and all log of CN in whole automation process , not just the log generated during this case. I don't think dump console log in xcattest log is not a good option.
The other thing is we have pull console log back, it do not need to dump log here.
|
I have reviewed the change and agree to merge. Thanks @junxiawang . |
Refine test case: nodeset_cmdline, nodeset_runimage, nodeset_shell #2833
1 Fix issue #2442
2 Fix issue #1871
3 make code clearly for anyone to debug.
During this pull request I modify genesis releated testcase:
1.remove the dependency of perl-xCAT package by xCAT-test
2.add debug information for this testcase to make code clearly for anyone to debug