Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance rinv for OpenPower Servers #990

Merged
merged 1 commit into from
Apr 29, 2016
Merged

Enhance rinv for OpenPower Servers #990

merged 1 commit into from
Apr 29, 2016

Conversation

zet809
Copy link

@zet809 zet809 commented Apr 27, 2016

The rinv output "Received incorrect data from BMC for FRU ID: xxx", but some of the FRU data can be read with ipmitool. This pull request is used to fix this issue.

rinv c910f05c31 | grep "Received incorrect data" | sort

c910f05c31: Received incorrect data from BMC for FRU ID: 15 -- Can get value with ipmitool
c910f05c31: Received incorrect data from BMC for FRU ID: 4 -- Can get value with ipmitool
c910f05c31: Received incorrect data from BMC for FRU ID: 44
c910f05c31: Received incorrect data from BMC for FRU ID: 45
c910f05c31: Received incorrect data from BMC for FRU ID: 47 -- Miss ID 46 and duplicate FRU ID
c910f05c31: Received incorrect data from BMC for FRU ID: 47
c910f05c31: Received incorrect data from BMC for FRU ID: 49 -- Miss ID 48, and can get value with ipmitool for FRU ID 49
c910f05c31: Received incorrect data from BMC for FRU ID: 50
c910f05c31: Received incorrect data from BMC for FRU ID: 51
c910f05c31: Received incorrect data from BMC for FRU ID: 52
c910f05c31: Received incorrect data from BMC for FRU ID: 53
c910f05c31: Received incorrect data from BMC for FRU ID: 54

@zet809 zet809 added this to the 2.12 milestone Apr 27, 2016
my $text = "Received incorrect data from BMC for FRU ID: " . $sessdata->{currfruid};
xCAT::SvrUtils::sendmsg($text,$callback,$sessdata->{node},%allerrornodes);
return;
# Fix FRU 43,48 and 49 for Garrison server that they can not return as much data as shall return
Copy link
Contributor

@daniceexi daniceexi Apr 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zet809 Could you change the server name to capital 'GRS', we cannot use the dev code for the new server.

@whowutwut whowutwut changed the title Enhance rinv for garrison server Enhance rinv for OpenPower Servers Apr 29, 2016
@zet809
Copy link
Author

zet809 commented Apr 29, 2016

@daniceexi Modified, pls review.

@daniceexi
Copy link
Contributor

I have reviewed the change and agree to merge.

@daniceexi daniceexi merged commit ae5ce53 into xcat2:master Apr 29, 2016
@whowutwut
Copy link
Member

@zet809 Can you add some description about the issue and what the pull request fixes., Some examples about the symptoms. I'm thinking this is to fix the Received incorrect data from BMC messages?

Does this also resolve Issue #233 and #234? If so, maybe we should re-open those issues and ask @tingtli to verify and close it out. We might also want to cherry pick this back to the 2.11 branch since that is the first release that supported the IBM OpenPOwer 822LC boxes and it was never resolved....

@zet809
Copy link
Author

zet809 commented Jul 26, 2016

@whowutwut You are right that this pull request is used to fix the "Received incorrect data from BMC" message. But, only the FRU whose data can be read with ipmitool is resolved.
It make the output message better for issue #233, and no more help for #234
#rinv c910f05c35 all | grep -i "FRU ID"
c910f05c35: Received incorrect data from BMC for FRU ID: 50
c910f05c35: Received incorrect data from BMC for FRU ID: 51
c910f05c35: Received incorrect data from BMC for FRU ID: 52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants