Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SHA-1 flag for code signing #96

Merged
merged 1 commit into from Mar 27, 2020

Conversation

michaeleisel
Copy link
Contributor

This improves incremental build time by using a faster signing algo (I believe the default is SHA-256). I don't know of any issues with this, and have used it successfully on both real devices and simulators, although feel free to chime in if there are any potential pitfalls.

@diederich
Copy link
Collaborator

The interwebs bring nothing up for me regarding this, which is a little surprising.

Though I saw your repos. And yes, if that improves incremental build times, I'm all in :-)

@michaeleisel
Copy link
Contributor Author

It's an undocumented flag that you can find in https://opensource.apple.com/source/security_systemkeychain/security_systemkeychain-55202/src/codesign.cpp.auto.html, and then if you read through /usr/bin/codesign's contents you can find the options. I'll do a little more double-checking and then merge if all goes well

@diederich
Copy link
Collaborator

Thanks for the pointers @michaeleisel!
Did you do any performance comparisons?

@michaeleisel
Copy link
Contributor Author

Yeah I've found for two different projects it significantly speeds things up. I forget the numbers for the first, but the second went from 2.7s to 1.7s

@diederich
Copy link
Collaborator

OK, wow, that sounds definitely worth it. It must be doing a lot of hashing.. 😂

Happy to merge if you're done with testing.

@michaeleisel
Copy link
Contributor Author

I've tested and am good with this merging

@diederich diederich merged commit 355666c into xcconfigs:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants