Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xchain-cosmos] Changes needed to support Ledger #603

Merged
merged 5 commits into from
Jul 1, 2022
Merged

[xchain-cosmos] Changes needed to support Ledger #603

merged 5 commits into from
Jul 1, 2022

Conversation

veado
Copy link
Collaborator

@veado veado commented Jun 27, 2022 •
edited
Loading

xchain-cosmos

Add

  • Helpers getDefaultRootDerivationPaths. getChainId, getChainIds, protoFee, protoMsgSend, protoTxBody, protoAuthInfo

Breaking change

  • Helper getDenom supports ATOM only + returns null for all other assets
  • Remove CosmosSDKClient.getUnsignedTxBody
  • Rename asset -> denom in TransferParams
  • Change type of amount from string -> BaseAmount in TransferParams
  • Remove account param from CosmosSDKClient.signAndBroadcast in favour of accountNumber

Update

  • Bump xchain-cosmos@0.19.0-alpha.1

xchain-thorchain

  • Bump xchain-thorchain@0.21.3-alpha.1

@veado veado self-assigned this Jun 27, 2022
@veado veado mentioned this pull request Jun 30, 2022
Merged
5 tasks
@veado veado marked this pull request as ready for review July 1, 2022 10:38
@veado veado merged commit 58fd945 into master Jul 1, 2022
@veado veado deleted the feat/cosmos-ledger-pt1 branch July 1, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@veado veado

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@veado