629 add xchain dash #635
Closed
629 add xchain dash #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ddress to vout 2 rather than the dashcore default of last
Closed
|
@alexdcox Thx for your PR + sorry for the late response! Pls fix conflicts, a review will be follow right after that. Can you join THORChain Discord (channel #xchainjs) https://discord.com/invite/pHcS67yX7Z to coordinate next steps for xchain-dash with the team? Thanks! |
Thorian1te
reviewed
May 22, 2023
There was a problem hiding this comment.
Hey, @alexdcox are you able to fix the conflicts with this package, its behind the master by a far amount of commits
Closed
Thorian1te
added a commit
that referenced
this pull request
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks good to me. How about you?