Add global attribute api protocols #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zklgame
reviewed
Oct 20, 2023
api-schema/xdb.yaml
Outdated
| # dbHint: | ||
| # type: string | ||
| # description: some additional info for how to use the dbColumn and dbQueryValue | ||
| GlobalAttributeRequest: |
There was a problem hiding this comment.
Should we add the verb on so that making the name to LoadGlobalAttributeRequest?
There was a problem hiding this comment.
And maybe make it plural -> LoadGlobalAttributesRequest
There was a problem hiding this comment.
Yeah good idea
zklgame
reviewed
Oct 20, 2023
api-schema/xdb.yaml
Outdated
| $ref: '#/components/schemas/GlobalAttributeValue' | ||
| error: | ||
| $ref: '#/components/schemas/GlobalAttributeLoadingError' | ||
| TableReadLocking: |
There was a problem hiding this comment.
Add Policy on to make the naming more consistent?
zklgame
approved these changes
Oct 20, 2023
longquanzheng
force-pushed
the
glo-att
branch
from
f13969e
to
fc8a7cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.