fix get_thumbnail to download entire graphic #28
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first time using GitHub, and first time writing Python, so apologies if I'm doing this wrong!
My issue was that downloading thumbnails did not retrieve all of the data from The Frame. A 59K png only received about 3K, and then stopped. So I added a while loop that keeps downloading until the socket is finished sending data (e.g. header['fileLength'])
This was my test code that was failing to download the entire png:
thumbnail = tv.art().get_thumbnail('MY_F0011')
file = open('MY_F0011.png', 'wb')
data = file.write(thumbnail)
file.close()