Compiling in single precision failing

[ricardofrantz]

Hello! Trying to compile in single with Intel or GCC and it's impossible.

mpiifort -fpp -O3 -ipo -fp-model fast=2 -mcmodel=large -safe-cray-ptr -I/lib -qmkl -I./src -I./decomp2d -fpp -O3 -ipo -fp-model fast=2 -mcmodel=large -safe-cray-ptr -I/lib -qmkl -DVERSION=\"\"  -I/opt/intel/oneapi/mkl/2021.4.0/include -c src/ibm.f90
src/ibm.f90(533): error #6633: The type of the actual argument differs from the type of the dummy argument.   [XA]
		            call cubic_spline(xa,ya,na,xpol,ypol)
----------------------------------------------^
src/ibm.f90(533): error #6633: The type of the actual argument differs from the type of the dummy argument.   [YA]
		            call cubic_spline(xa,ya,na,xpol,ypol)
-------------------------------------------------^
src/ibm.f90(533): error #6633: The type of the actual argument differs from the type of the dummy argument.   [XPOL]
		            call cubic_spline(xa,ya,na,xpol,ypol)
-------------------------------------------------------^
src/ibm.f90(533): error #6633: The type of the actual argument differs from the type of the dummy argument.   [YPOL]
		            call cubic_spline(xa,ya,na,xpol,ypol)
------------------------------------------------------------^
src/ibm.f90(697): error #6633: The type of the actual argument differs from the type of the dummy argument.   [XA]
		            call cubic_spline(xa,ya,na,xpol,ypol)
----------------------------------------------^
src/ibm.f90(697): error #6633: The type of the actual argument differs from the type of the dummy argument.   [YA]
		            call cubic_spline(xa,ya,na,xpol,ypol)
-------------------------------------------------^
src/ibm.f90(697): error #6633: The type of the actual argument differs from the type of the dummy argument.   [XPOL]
		            call cubic_spline(xa,ya,na,xpol,ypol)
-------------------------------------------------------^
src/ibm.f90(697): error #6633: The type of the actual argument differs from the type of the dummy argument.   [YPOL]
		            call cubic_spline(xa,ya,na,xpol,ypol)
------------------------------------------------------------^
src/ibm.f90(850): error #6633: The type of the actual argument differs from the type of the dummy argument.   [XA]
	                          call cubic_spline(xa,ya,na,xpol,ypol)
----------------------------------------------------^
src/ibm.f90(850): error #6633: The type of the actual argument differs from the type of the dummy argument.   [YA]
	                          call cubic_spline(xa,ya,na,xpol,ypol)
-------------------------------------------------------^
src/ibm.f90(850): error #6633: The type of the actual argument differs from the type of the dummy argument.   [XPOL]
	                          call cubic_spline(xa,ya,na,xpol,ypol)
-------------------------------------------------------------^
src/ibm.f90(850): error #6633: The type of the actual argument differs from the type of the dummy argument.   [YPOL]
	                          call cubic_spline(xa,ya,na,xpol,ypol)
------------------------------------------------------------------^
....
src/acl_utils.f90(94): error #8209: If type specification is omitted, each element in an array-constructor must have the same type and kind type parameters.   [VOX]
   p=reshape([0.0d0,vOx,vOy,vOz],[4,1])
--------------------^
src/acl_utils.f90(94): error #8209: If type specification is omitted, each element in an array-constructor must have the same type and kind type parameters.   [VOY]
   p=reshape([0.0d0,vOx,vOy,vOz],[4,1])
------------------------^
src/acl_utils.f90(94): error #8209: If type specification is omitted, each element in an array-constructor must have the same type and kind type parameters.   [VOZ]
   p=reshape([0.0d0,vOx,vOy,vOz],[4,1])
----------------------------^
...
src/acl_elem.f90(620): error #6633: The type of the actual argument differs from the type of the dummy argument.   [0.0D0]
        Call QuatRot(txtmp,tytmp,tztmp,theta,nrx,nry,nrz,0.0d0,0.0d0,0.0d0,vrx,vry,vrz)
---------------------------------------------------------^
src/acl_elem.f90(620): error #6633: The type of the actual argument differs from the type of the dummy argument.   [0.0D0]
        Call QuatRot(txtmp,tytmp,tztmp,theta,nrx,nry,nrz,0.0d0,0.0d0,0.0d0,vrx,vry,vrz)
---------------------------------------------------------------^
src/acl_elem.f90(620): error #6633: The type of the actual argument differs from the type of the dummy argument.   [0.0D0]
        Call QuatRot(txtmp,tytmp,tztmp,theta,nrx,nry,nrz,0.0d0,0.0d0,0.0d0,vrx,vry,vrz)
---------------------------------------------------------------------^
...

it goes like this in several places inside acl_*

and with GCC also:

mpif90 -cpp -O3 -funroll-loops -floop-optimize -g -Warray-bounds -fcray-pointer -fbacktrace -ffree-line-length-none -fallow-argument-mismatch -I./src -I./decomp2d -cpp -O3 -funroll-loops -floop-optimize -g -Warray-bounds -fcray-pointer -fbacktrace -ffree-line-length-none -fallow-argument-mismatch -DVERSION=\"\"   -c src/dynstall_legacy.f90
src/dynstall_legacy.f90:365:36:

  365 |     dCDF=KD*(CLstat-CLF)*sign(1.0d0,CLstat)
      |                                    1
Error: ‘b’ argument of ‘sign’ intrinsic at (1) must be the same type and kind as ‘a’
src/dynstall_legacy.f90:378:19:

  378 |     if (sign(1.0d0,lb%dcv*lb%CLRefLE)<0 .OR. abs(alphaL-AOA0)>acut .OR. lb%CLRateFlag<0) then
      |                   1
Error: ‘b’ argument of ‘sign’ intrinsic at (1) must be the same type and kind as ‘a’
make: *** [Makefile:107: src/dynstall_legacy.o] Error 1

[slaizet]

Hi Ricardo,
Can you try to compile with https://github.com/xcompact3d/Incompact3d/tree/merging/stfc? It is the newest branch which is about to be merged to the master branch as soon as we are done with the final checks.
Cheers,
Sylvain

[ricardofrantz]

Hi, it is indeed compiling with the latest OneApi in both single and double! Good job! Em seg., 18 de out. de 2021 às 15:25, slaizet ***@***.***> escreveu:

…

Hi Ricardo, Can you try to compile with https://github.com/xcompact3d/Incompact3d/tree/merging/stfc. It is the newest branch which is about to be merged to the master branch as soon as we are done with the final checks. Cheers, Sylvain — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#54 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABAGNT7BCTER7CK3G2UNLH3UHQN5BANCNFSM5FPDBM4A> .