Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement an iterative Poisson solver #69

Draft
wants to merge 53 commits into
base: main
Choose a base branch
from
Draft

Implement an iterative Poisson solver #69

wants to merge 53 commits into from

Conversation

pbartholomew08
Copy link
Member

This is based off the Poisson branch #32 and adds the interface to PETSc as an alternative Poisson solver.

semi-h and others added 30 commits February 19, 2024 11:46
@semi-h
Add a Poisson solver selection mechanism.
7a342be
@semi-h
Implement a dedicated class for the FFT based Poisson solver.
bcd1056
@semi-h
Store compact scheme coefficients in tdsops class.
e6c488b
@semi-h
Store domain length and dx in dirps_t.
d4c6831
@semi-h
Change the way we initialise poisson_fft class.
d0d11d9
@semi-h
Construct the waves array for all periodic BCs.
9cbdf95
@semi-h
Create cufft plans.
9d36b6b
@semi-h
Add postprocessing in spectral space.
bcbaf18
@pbartholomew08
Merge branch 'poisson' into 44-poisson-solver-iterative-solver
2b648d2
@pbartholomew08
Ignore emacs project configuration file
11a6960
@pbartholomew08
Merge branch 'main' into 44-poisson-solver-iterative-solver
fad59f1
@semi-h
Add a Poisson solver selection mechanism.
257b4ee
@semi-h
Implement a dedicated class for the FFT based Poisson solver.
87f0763
@semi-h
Store compact scheme coefficients in tdsops class.
dc3fe5c
@semi-h
Store domain length and dx in dirps_t.
7d67a0e
@semi-h
Change the way we initialise poisson_fft class.
bbe17d6
@semi-h
Construct the waves array for all periodic BCs.
266c3a9
@semi-h
Create cufft plans.
b1a3589
@semi-h
Add postprocessing in spectral space.
b138b40
@semi-h
Store plans at poisson_fft class level.
4953d87
@semi-h
Add forward FFT transforms.
4cde72d
@semi-h
Add backward FFT transforms.
178c920
@semi-h
Fix allocation size of the waves array on GPU.
7893007
@semi-h
Change shape of the c_x/y/z arrays.
de51f15
@semi-h
Add postprocessing kernel call.
994e83e
@semi-h
Add complex reordering functions.
f609516
@semi-h
Call complex reordering functions in forward and backward FFTs.
1f5564a
@semi-h
No need to initialise backends with dirps any more.
add29cc
@semi-h
Cleanups.
b982e52
@semi-h
Cleanup and style fix.
8e1f39b
@pbartholomew08 pbartholomew08 self-assigned this Mar 5, 2024
@pbartholomew08 pbartholomew08 linked an issue Mar 5, 2024 that may be closed by this pull request
Poisson solver (iterative solver) #44
Open
@pbartholomew08
Copy link
Member Author

Note this currently appears as a larger change due to changes in the main/FFT Poisson branch, once merged into main this PR should appear smaller.

@pbartholomew08
Copy link
Member Author

Currently the m_poisson_cg module is PETSc dependent, building this will require PETSc. This is only to get the basic structure outlined, after this I will lift this into a submodule (cf omp/cuda backends) to remove the hard dependency.

@pbartholomew08
Make the possmult subroutine iterative-solver independent
f7cf502 
Computing the action of the Laplacian should be handled by the
discretisation backends, the iterative solver implementation just
needs to handle packing/unpacking data into this.
@semi-h
Copy link
Member

semi-h commented Mar 5, 2024

I hope the last bit of changes in #32 didn't cause merge conflicts here. I think we can merge #32 tomorrow so it'll be easier to review this.

@pbartholomew08
Copy link
Member Author

I hope the last bit of changes in #32 didn't cause merge conflicts here. I think we can merge #32 tomorrow so it'll be easier to review this.

No problem, this is still very WIP, I've been basing this off #32 and trying to pull in updates to main too - so I think once it is merged they will either go away or be easy to resolve. Most of the changes shown here come from #32 I think anyway.

@pbartholomew08
Copy link
Member Author

Merge conflicts resolved :)

@pbartholomew08 pbartholomew08 force-pushed the 44-poisson-solver-iterative-solver branch from 0a4dfb8 to 332cf8e Compare April 2, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pbartholomew08 pbartholomew08

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Poisson solver (iterative solver)
2 participants
@pbartholomew08 @semi-h