Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert as-*'s arguments using defn prepost-map #19

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

federkasten
Copy link
Member

According to #17, I have refactored as-* function's argument validation using defn's prepost-map then addded more test cases for them.

@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Patch coverage: 92.10% and project coverage change: -1.95 ⚠️

Comparison is base (2259d38) 96.35% compared to head (fe3b084) 94.40%.

❗ Current head fe3b084 differs from pull request most recent head c003dd5. Consider uploading reports for the commit c003dd5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   96.35%   94.40%   -1.95%     
==========================================
  Files           5        9       +4     
  Lines         192      286      +94     
  Branches        3        4       +1     
==========================================
+ Hits          185      270      +85     
- Misses          4       12       +8     
- Partials        3        4       +1     
Impacted Files Coverage Δ
src/cljc/proton/core.cljc 93.68% <92.00%> (-1.50%) ⬇️
src/cljc/proton/function.cljc 92.30% <92.30%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@iku000888 iku000888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iku000888 iku000888 merged commit 25fa1c9 into master May 4, 2023
@iku000888 iku000888 deleted the fix/assertion branch May 4, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants