Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string pruning function #5

Merged
merged 1 commit into from
Dec 28, 2017
Merged

Add string pruning function #5

merged 1 commit into from
Dec 28, 2017

Conversation

totakke
Copy link
Member

@totakke totakke commented Dec 27, 2017

Adds proton.string namespace and proton.string/prune function. prune is useful to shorten a long text with indicating the text is omitted.

@codecov
Copy link

codecov bot commented Dec 27, 2017

Codecov Report

Merging #5 into master will increase coverage by 0.88%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   91.33%   92.21%   +0.88%     
==========================================
  Files           4        5       +1     
  Lines         150      167      +17     
  Branches        3        3              
==========================================
+ Hits          137      154      +17     
  Misses         10       10              
  Partials        3        3
Impacted Files Coverage Δ
src/cljc/proton/string.cljc 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d3f3e7...12908f7. Read the comment docs.

@federkasten
Copy link
Member

Good enhancement. Thank you.

I would like to expand string utilities much more.

@federkasten federkasten merged commit 26276c2 into master Dec 28, 2017
@totakke totakke deleted the feature/string-prune branch December 28, 2017 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants