-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions for local ISO SR on multi host pool #185
Conversation
docs/storage.md
Outdated
@@ -492,7 +492,15 @@ a6732eb5-9129-27a7-5e4a-8784ac45df27 | |||
|
|||
xe sr-scan uuid=a6732eb5-9129-27a7-5e4a-8784ac45df27 | |||
``` | |||
If your host are in a pool, you need to get the host uuid first: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If your host are in a pool, you need to get the host uuid first: | |
If your host is in a pool of several hosts, you need to get the host uuid first: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does a local ISO SR work when the VM is on a different host of the pool? I don't think it does.
Indeed, the local ISO SR doestn't work on a VM on an other host of the pool |
Commit updated :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's my proposal to make it shorter while retaining the essential information.
Signed-off-by: Cécile MORANGE <contact@ataxya.net>
Signed-off-by: Cécile MORANGE <contact@ataxya.net>
Co-authored-by: Samuel Verschelde <stormi-xcp@ylix.fr> Signed-off-by: Cécile MORANGE <contact@ataxya.net>
I try to push your suggestion, but I think something went wrong 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added my missing suggestion again. You just need to approve it. No need to force push your branch, I'll squash the commits together when merging.
If I click on "sign off and commit suggestion", the DCO check will fail (that's why I have to force push). If you squash the commit after the DCO will be ok ? |
Yes, the DCO will be good in the end as I'll make sure the squashed commit retains your sign-off |
Co-authored-by: Samuel Verschelde <stormi-xcp@ylix.fr>
Ok, done ! |
It's merged. Thanks for your contribution :) |
I just have come across the following use case:
2 hosts in a pool, and wanted to create a Local ISO SR
If l follow the doc, I have this error:
So with xe host-list, I retrieve my host uuid:
Then I can create my SR:
I don't remember if a standalone XCP-ng have the same behavior (I don't think so), but I can test it if you want :)
Thank you for all your work !