Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for local ISO SR on multi host pool #185

Merged
merged 4 commits into from Jun 8, 2022

Conversation

AtaxyaNetwork
Copy link
Contributor

I just have come across the following use case:
2 hosts in a pool, and wanted to create a Local ISO SR
If l follow the doc, I have this error:

[19:33 Delirium ~]# xe sr-create name-label="ISO Repository" type=iso device-config:location=/opt/var/iso_repository device-config:legacy_mode=true content-type=iso
Error: Required parameter not found: host-uuid

So with xe host-list, I retrieve my host uuid:

[19:34 Delirium ~]# xe host-list 
uuid ( RO)                : 7b84f233-8aa3-468d-b254-fd585194da21
          name-label ( RW): Delirium
    name-description ( RW): heart beer

Then I can create my SR:

[19:34 Delirium ~]# xe sr-create name-label="ISO Repository" type=iso device-config:location=/opt/var/iso_repository device-config:legacy_mode=true content-type=iso host-uuid=7b84f233-8aa3-468d-b254-fd585194da21 
953fcd3b-a4d5-1092-c4eb-1782cee0ff0b

I don't remember if a standalone XCP-ng have the same behavior (I don't think so), but I can test it if you want :)

Thank you for all your work !

Before submitting the pull request, you must agree with the following statements by checking both boxes with a 'x'.

  • "I accept that my contribution is placed under the CC BY-SA 2.0 license [1]."
  • "My contribution complies with the Developer Certificate of Origin [2]."

[1] https://creativecommons.org/licenses/by-sa/2.0/
[2] https://xcp-ng.org/docs/contributing.html#developer-certificate-of-origin-dco

docs/storage.md Outdated
@@ -492,7 +492,15 @@ a6732eb5-9129-27a7-5e4a-8784ac45df27

xe sr-scan uuid=a6732eb5-9129-27a7-5e4a-8784ac45df27
```
If your host are in a pool, you need to get the host uuid first:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If your host are in a pool, you need to get the host uuid first:
If your host is in a pool of several hosts, you need to get the host uuid first:

Copy link
Member

@stormi stormi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does a local ISO SR work when the VM is on a different host of the pool? I don't think it does.

@AtaxyaNetwork
Copy link
Contributor Author

Indeed, the local ISO SR doestn't work on a VM on an other host of the pool
I think it's a good idea to specify this

@AtaxyaNetwork
Copy link
Contributor Author

Commit updated :)

Copy link
Member

@stormi stormi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's my proposal to make it shorter while retaining the essential information.

docs/storage.md Outdated Show resolved Hide resolved
docs/storage.md Outdated Show resolved Hide resolved
Signed-off-by: Cécile MORANGE <contact@ataxya.net>
Signed-off-by: Cécile MORANGE <contact@ataxya.net>
Co-authored-by: Samuel Verschelde <stormi-xcp@ylix.fr>
Signed-off-by: Cécile MORANGE <contact@ataxya.net>
@AtaxyaNetwork
Copy link
Contributor Author

I try to push your suggestion, but I think something went wrong 🤔

Copy link
Member

@stormi stormi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added my missing suggestion again. You just need to approve it. No need to force push your branch, I'll squash the commits together when merging.

docs/storage.md Outdated Show resolved Hide resolved
@AtaxyaNetwork
Copy link
Contributor Author

If I click on "sign off and commit suggestion", the DCO check will fail (that's why I have to force push). If you squash the commit after the DCO will be ok ?

@stormi
Copy link
Member

stormi commented Jun 8, 2022

Yes, the DCO will be good in the end as I'll make sure the squashed commit retains your sign-off

Co-authored-by: Samuel Verschelde <stormi-xcp@ylix.fr>
@AtaxyaNetwork
Copy link
Contributor Author

Ok, done !

@stormi stormi merged commit a6d74a0 into xcp-ng:master Jun 8, 2022
@stormi stormi changed the title Update doc storage Add instructions for local ISO SR on multi host pool Jun 8, 2022
@stormi
Copy link
Member

stormi commented Jun 8, 2022

It's merged. Thanks for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants