Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not check for xscontainer on XCP-ng #45

Closed
borzel opened this issue May 11, 2018 · 1 comment
Closed

Do not check for xscontainer on XCP-ng #45

borzel opened this issue May 11, 2018 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@borzel
Copy link
Member

borzel commented May 11, 2018

https://xcp-ng.org/forum/topic/82/xcp-ng-center-no-cloud-init-cloud-config-options-in-vm-properties-in/22

Extend this function, so that on XCP-ng hosts it always return true.

public static bool ContainerCapability(IXenConnection connection)
       {
           var master = GetMaster(connection);
           if (master == null)
               return false;
           if (ElyOrGreater(connection))
               return master.AppliedUpdates().Any(update => update.Name().ToLower().StartsWith("xscontainer")); 
           return CreamOrGreater(connection) && master.SuppPacks().Any(suppPack => suppPack.Name.ToLower().StartsWith("xscontainer")); 
       }
@borzel borzel changed the title Do not check for xscontainer on XCP-ng Do not check for xscontainer on XCP-ng May 11, 2018
@borzel borzel added this to the Release 7.4.2 milestone May 11, 2018
@borzel borzel added the bug Something isn't working label May 11, 2018
@borzel borzel self-assigned this May 13, 2018
@borzel
Copy link
Member Author

borzel commented May 13, 2018

Should now work with XCP-ng Center 7.4.2-RC2:
https://github.com/xcp-ng/xenadmin/releases/tag/v7.4.2-RC2

@borzel borzel closed this as completed May 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant