Insert packed input slice issue #317 #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d - not working yet
…fined. Addressing issue #317. Added test for replacing time slices when packing of variables is defined.
# Conflicts: # CHANGES.md
forman
requested changes
Jun 24, 2020
CHANGES.md
Outdated
| * From 0.4.1: Fixed time-series performance drop (#299). | ||
| ### Fixes | ||
| * From 0.4.1: Fixed time-series performance drop (#299). | ||
| * Fixed incorrect handling input slices with defined packing of variables when inserting |
There was a problem hiding this comment.
Missing a context here: Users have no idea where "incorrect handling input slice" will apply to. Say something like:
Suggested change
| * Fixed incorrect handling input slices with defined packing of variables when inserting | |
| * Fixed `xcube gen` CLI tool to correcly insert time slices into an existing cube stored as Zarr. (#317) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the incorrect insert of time-slices which have a defined packing of variables.
This relates to issue #317.