Fixing tests for accessing data from xcube server via python api #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonioF
reviewed
Jan 24, 2022
If you delete your .aws (or give it a different name) then you will see the error with the old code :) |
TonioF
approved these changes
Jan 24, 2022
forman
requested changes
Jan 26, 2022
Co-authored-by: Norman Fomferra <norman.fomferra@brockmann-consult.de>
…s_xcube_python_api' into alicja-574-fix_server_data_access_xcube_python_api
AliceBalfanz
deleted the
alicja-574-fix_server_data_access_xcube_python_api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only fixes the tests for test_s3buckethandlers.py when serving data the classical way: one dataset per identifyer, as in
examples/serve/demo/config.yml. The data access does not work yet for cubes served via DataStores like in the configexamples/serve/demo/config-with-stores.ymlChecklist:
Add unit tests and/or doctests in docstringsAdd docstrings and API docs for any new/modified user-facing classes and functionsNew/modified features documented indocs/source/*Changes documented inCHANGES.mdRemember to close associated issues after merge!