Remove code setting up "-no-pie" #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustc 1.26 now handles passing -no-pie to the linker when "relocation-model=dynamic-no-pic" is passed. rustc handles it better than we can, however, as it only passes it to the final binary and we can only force it for everything, including proc_macro crates, which should be excluded. Leaving this code in interferes with the fix made in rustc. Signed-off-by: Gabriel Smith <ga29smith@gmail.com>
This tests that any issues involving proc macros and -no-pie stay resolved. Signed-off-by: Gabriel Smith <ga29smith@gmail.com>
|
Just tested it and it's all good my end! You're officially my favourite person of the week, that issue has been a thorn in my side since it was opened ❤️ |
|
Glad to be of service! This was definitely a thorn in my side as well. It never feels good when your code only partially works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits remove the code I added so long ago that added "-no-pie" when required. This code caused some problems, mainly with anything using proc macros.
rustcnow handles this for us, and in a better way so we no longer need this code.A test is also included and is set to run with a normal call to
cargo test. I ran the test both with and without the removed code to be sure that this actually fixed the issue. If you would not like this test to run by default, please let me know and I will modify the test.I can't say I have ever been so happy to remove all of my code from a codebase before.
Fixes #23