Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overblocking Nimiq related applications #31

Closed
mar-v-in opened this issue Oct 24, 2018 · 3 comments
Closed

Overblocking Nimiq related applications #31

mar-v-in opened this issue Oct 24, 2018 · 3 comments

Comments

@mar-v-in
Copy link

mar-v-in commented Oct 24, 2018

I noticed your extension filters (which were just embedded by EasyPrivacy) is overblocking some Nimiq related applications.

The relevant entries are

  • nimiq.watch
  • nimiqtest.net

nimiq.watch is a Nimiq block explorer service. It provides an API under api.nimiq.watch domain that is used by third-parties to access its services. There is also a mining pool hosted under pool.nimiq.watch, which you might want to continue to block (as it might be used by mining clients embedded into third-party websites, although I doubt it), but should not cause the api service to be blocked.

nimiqtest.net is the host name of some network nodes in the nimiq testnet network. These nodes do provide all the information that can be gathered from the testnet, but not any logic for mining. Although some miners might optionally connect to these hosts, it is not a requirement, so it makes no sense to block the host to block mining. However some client web applications, most notably https://safe.nimiq-testnet.com/, the standard client to access the nimiq testnet, require access to these hosts.

Please remove these two filters (or at least for the case of nimiq.watch, update it) to no longer overblock Nimiq web apps.

@xd4rker
Copy link
Owner

xd4rker commented Oct 25, 2018

Hi, sorry if it's interfering with Nimiq's related apps. Does adding those fix the issue ?

*://cdn.nimiq.com/nimiq.js*
wss://pool.nimiq.watch/*
wss://node.nimiqpool.com/*
wss://pool.porkypool.com/*
wss://pool.nimiqchain.info/*
wss://eu.nimpool.io/*
wss://node.philpool.com/*
wss://eu.sushipool.com/*

@mar-v-in
Copy link
Author

mar-v-in commented Oct 28, 2018

*://cdn.nimiq.com/nimiq.js* is definitely causing even more applications to break: These files contain the logic to connect to the p2p network for running nimiq apps. The other filters look ok to me.

xd4rker added a commit that referenced this issue Nov 9, 2018
@xd4rker
Copy link
Owner

xd4rker commented Nov 9, 2018

Closing this as it has been fixed in 9037ab3. Please feel free to re-open if necessary.

@xd4rker xd4rker closed this as completed Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants