Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkedIn sharing #8

Closed
wants to merge 2 commits into from
Closed

LinkedIn sharing #8

wants to merge 2 commits into from

Conversation

hansvangent
Copy link

LinkedIn sharing added

@xdamman
Copy link
Owner

xdamman commented Feb 16, 2015

Great thanks!

Now that we start having more services, it would be great to have an easy way to choose which ones the user wants. E.g. when we instantiate it:

<script>
$('p').selectionSharer({twitter:true,facebook:true,linkedin:false});
</script>

@AlienSKP
Copy link

Yes I was thinking the same. Ill try to do it sometimes tonight or tomorrow
On Feb 16, 2015 12:47 PM, "Xavier Damman" notifications@github.com wrote:

Great thanks!

Now that we start having more services, it would be great to have an easy
way to choose which ones the user wants. E.g. when we instantiate it:

<script> $('p').selectionSharer({twitter:true,facebook:true,linkedin:false}); </script>


Reply to this email directly or view it on GitHub
#8 (comment)
.

@hansvangent
Copy link
Author

Cool, was thinking about it too, with some more settings even for the Wordpress plugin like setting your own customer URL shortener etc.

@xdamman
Copy link
Owner

xdamman commented Jun 23, 2015

Sorry, apparently this never got merged. Can you rebase so that it can be merged automatically?

@hansvangent
Copy link
Author

What do you mean with rebase it?

@xdamman
Copy link
Owner

xdamman commented Jun 23, 2015

I mean pulling master back into your pull request branch and post it again.

On Jun 23, 2015, at 4:24 PM, Hans van Gent notifications@github.com wrote:

What do you mean with rebase it?


Reply to this email directly or view it on GitHub.

@cmalexander
Copy link

Did LinkedIn ever get added to this? If so, I would love to know how to add it.

@shri3k
Copy link
Collaborator

shri3k commented Dec 3, 2018

@cmalexander I don't think it ever did due to merge conflict on the PR. I'll see what I can do this evening.

Edit: I went ahead and added the "LinkedIn" share capabilities in feat-linkedin branch now. Feel free to test this until I build a release for it.

@shri3k
Copy link
Collaborator

shri3k commented Dec 8, 2018

@cmalexander alright. It should be there now. Will probably need to bump the version to 1.1.0 if you're using npm.

@shri3k
Copy link
Collaborator

shri3k commented Dec 8, 2018

Closing. Feel free to open an issue if there are any for this.

@shri3k shri3k closed this Dec 8, 2018
@cmalexander
Copy link

cmalexander commented Dec 10, 2018

Thanks so much @shri3k! Really appreciate it!

@cmalexander
Copy link

Hi @shri3k. Thanks again for your help. LinkedIn is appearing, but when I highlight text and select LinkedIn there is no text transferred to the pop-up window. Is there something else I need to do besides include the .js and .css files?

@shri3k
Copy link
Collaborator

shri3k commented Dec 30, 2018

Hey @cmalexander sorry it took me a while to get to this but LinkedIn and Facebook usually follows Open Graph Protocol and if not found they have their own algorithm to analyze and display what's on the page that you're sharing.
This is however a bit different in Twitter where they share exactly what you selected.

That said, you can control what LinkedIn and other media sharing platform displays by adding few OGP tags.
Facebook Open Graph
LinkedIn Open Graph - scroll down to "Improve content sharing with Open Graph"

Hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants