-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LinkedIn sharing #8
Conversation
Great thanks! Now that we start having more services, it would be great to have an easy way to choose which ones the user wants. E.g. when we instantiate it:
|
Yes I was thinking the same. Ill try to do it sometimes tonight or tomorrow
|
Cool, was thinking about it too, with some more settings even for the Wordpress plugin like setting your own customer URL shortener etc. |
Sorry, apparently this never got merged. Can you rebase so that it can be merged automatically? |
What do you mean with rebase it? |
I mean pulling master back into your pull request branch and post it again.
|
Did LinkedIn ever get added to this? If so, I would love to know how to add it. |
@cmalexander I don't think it ever did due to merge conflict on the PR. I'll see what I can do this evening. Edit: I went ahead and added the "LinkedIn" share capabilities in feat-linkedin branch now. Feel free to test this until I build a release for it. |
@cmalexander alright. It should be there now. Will probably need to bump the version to |
Closing. Feel free to open an issue if there are any for this. |
Thanks so much @shri3k! Really appreciate it! |
Hi @shri3k. Thanks again for your help. LinkedIn is appearing, but when I highlight text and select LinkedIn there is no text transferred to the pop-up window. Is there something else I need to do besides include the .js and .css files? |
Hey @cmalexander sorry it took me a while to get to this but LinkedIn and Facebook usually follows Open Graph Protocol and if not found they have their own algorithm to analyze and display what's on the page that you're sharing. That said, you can control what LinkedIn and other media sharing platform displays by adding few OGP tags. Hope that helps. |
LinkedIn sharing added