Fixed bug #985: The current Git head does not compile anymore for Windows #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -90,7 +90,7 @@ | |||
| int xdebug_is_output_tty(); | |||
| #endif | |||
|
|
|||
| extern ZEND_API void (*xdebug_external_error_cb)(int type, const char *error_filename, const uint error_lineno, const char *format, va_list args) ZEND_ATTRIBUTE_PTR_FORMAT(printf, 4, 0); | |||
| void (*xdebug_external_error_cb)(int type, const char *error_filename, const uint error_lineno, const char *format, va_list args); | |||
There was a problem hiding this comment.
Wouldn't this be better in xdebug_private.h perhaps?
|
This introduced memory corruption. See my notes at http://bugs.xdebug.org/view.php?id=985 |
|
I am closing this. I did remove the code so it also should no longer cause issues. @Jan-E — I would appreciate it if you could confirm my statement on this. |
|
Confirmed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentatively fixes: http://bugs.xdebug.org/view.php?id=985 (untested)