Raise default max nesting level #910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derickr
added a commit
that referenced
this pull request
Sep 18, 2023
|
I have merged this after creating a ticket as per contributing guidelines. I have not pushed the changes to |
|
Hah, real programmers don't read comments! 😉 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown in symfony/symfony#48515 it is currently possible with basic Symfony projects to trigger the default max_nesting_level of 256 during DI container compilation.
As it's more important that there is a limit than its specific number we should ensure that the defaults continue to work in (almost) all regular situations with common tools and libraries. I think we should therefore raise the default limit to 512.