Expose __EXCEPTION virtual variable for current EG(exception) #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I'm generally OK with this, but it confuses me that tests on Windows are not failing, whereas there is a test (I think rightfully) failing on Linux. And of course, we need tests :-) |
derickr
requested changes
Mar 22, 2024
There was a problem hiding this comment.
I think this should be guarded by a feature set, as we discussed in our meeting. The reason is that otherwise IDEs could suddenly see this extra virtual variable, without knowing why.
The PR should also add tests to check whether this new feature works. I don't think we should not fix the currently failing test, as it has not opted in into this new behaviour.
zobo
force-pushed
the
dbgp_exception
branch
3 times, most recently
from
4b2e337
to
d59bf03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be a way to expose the current Exception that is in EG(exception). I have tested this with VSC and it does indeed work.
However, I think a better way would be to provide a dynamic context name when an exception is available.. Same with return value. Maybe....
I have not written any tests for this yet.