Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add URL module and fix error messages in CLI #17

Merged
merged 2 commits into from
Feb 27, 2020
Merged

Add URL module and fix error messages in CLI #17

merged 2 commits into from
Feb 27, 2020

Conversation

iamdaniele
Copy link
Contributor

Problem

As per #16, users can get a ReferenceError: URL is not defined when using Autohook

Solution

Autohook now explicitly requires the URL object from Node's url library.

@iamdaniele iamdaniele self-assigned this Feb 26, 2020
tonyv
tonyv approved these changes Feb 27, 2020
View reviewed changes
Copy link

@tonyv tonyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iamdaniele iamdaniele merged commit 6d4bfba into master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyv tonyv tonyv approved these changes

@OiHamza-zz OiHamza-zz Awaiting requested review from OiHamza-zz

Assignees

@iamdaniele iamdaniele

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iamdaniele @tonyv