-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Autohook silently failing issue #36 #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sachushaji for the PR! ✨ I'm requesting a few changes before we can give it a #shipit and package.
Thanks @iamdaniele for the detailed review. I have made some changes. For the style issues, I think it would be great if we have a eslint config enforcing them so that we can see it right away from the code editor. |
Problem
By default, ngrok tunnels without an authtoken will be terminated within a certain time period thereby failing silently the autohook after a few hours of uptime.
Solution
Result
This will solve the issue at which autohook silently stops listening to requests after certain hours of uptime. It will potentially solve issue #36