Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Autohook silently failing issue #36 #37

Merged
merged 6 commits into from
Aug 5, 2020
Merged

fix: Autohook silently failing issue #36 #37

merged 6 commits into from
Aug 5, 2020

Conversation

sachushaji
Copy link
Contributor

@sachushaji sachushaji commented Aug 4, 2020

Problem

By default, ngrok tunnels without an authtoken will be terminated within a certain time period thereby failing silently the autohook after a few hours of uptime.

Solution

  • Added provision to pass ngrok authtoken so that if authtoken is passed, it will make a connection using auth token giving a stable ngrok tunnel to connect to.

Result

This will solve the issue at which autohook silently stops listening to requests after certain hours of uptime. It will potentially solve issue #36

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2020

CLA assistant check
All committers have signed the CLA.

@sachushaji sachushaji changed the title Fix Autohook issue 36 fix: Autohook silently failing issue #36 Aug 4, 2020
@iamdaniele iamdaniele self-assigned this Aug 4, 2020
Copy link
Contributor

@iamdaniele iamdaniele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sachushaji for the PR! ✨ I'm requesting a few changes before we can give it a #shipit and package.

examples/standalone-server.js Outdated Show resolved Hide resolved
examples/standalone-server.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@sachushaji
Copy link
Contributor Author

Thanks @iamdaniele for the detailed review. I have made some changes. For the style issues, I think it would be great if we have a eslint config enforcing them so that we can see it right away from the code editor.

@iamdaniele iamdaniele merged commit e2b4733 into xdevplatform:master Aug 5, 2020
@sachushaji sachushaji deleted the autohook-issue-36 branch August 5, 2020 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants