added twitter tracking pixel #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, @brinnpaul! The team will take a look this coming week. |
juanshishido
requested changes
Apr 19, 2017
| from twitter_ads.http import Request | ||
| from twitter_ads.cursor import Cursor | ||
|
|
||
| class Pixel(Resource, Persistence): |
There was a problem hiding this comment.
Would prefer a different name, but not sure what that should be
| @@ -136,6 +136,12 @@ def media_creatives(self, id=None, **kwargs): | |||
| """ | |||
| return self._load_resource(MediaCreative, id, **kwargs) | |||
|
|
|||
| def pixel(self, id=None, **kwargs): | |||
There was a problem hiding this comment.
Would prefer a different name, but not sure what that should be
| @@ -0,0 +1,25 @@ | |||
| from twitter_ads.enum import TRANSFORM | |||
There was a problem hiding this comment.
TRANSFORM isn't used here
| @@ -0,0 +1,25 @@ | |||
| from twitter_ads.enum import TRANSFORM | |||
| from twitter_ads.resource import resource_property, Resource, Persistence, Batch, Analytics | |||
There was a problem hiding this comment.
Batch and Analytics aren't used here
| @@ -0,0 +1,25 @@ | |||
| from twitter_ads.enum import TRANSFORM | |||
| from twitter_ads.resource import resource_property, Resource, Persistence, Batch, Analytics | |||
| from twitter_ads.http import Request | |||
There was a problem hiding this comment.
Request isn't used here
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.