Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing/Printing: print result type at the end of an operation #28

Closed
tobiasgrosser opened this issue Dec 24, 2021 · 1 comment
Closed

Comments

@tobiasgrosser
Copy link
Contributor

tobiasgrosser commented Dec 24, 2021

I would prefer to parse the type after an assignment to be more in line with what MLIR uses. I also find the delayed type easier to read as the interesting information, the operation that we call, is frontloaded.

Instead of:

%0 : !riscv_ssa.reg = riscv_ssa.li() ["immediate" = 42 : !i64]
%1 : !riscv_ssa.reg = riscv_ssa.mul(%0 : !riscv_ssa.reg, %0 : !riscv_ssa.reg)

I would expect to read:

%0 = riscv_ssa.li() ["immediate" = 42 : !i64] : !riscv_ssa.reg 
%1 = riscv_ssa.mul(%0 : !riscv_ssa.reg, %0 : !riscv_ssa.reg) : !riscv_ssa.reg 
@tobiasgrosser tobiasgrosser changed the title Parsing/Printing Parsing/Printing: print result type at the end of an operation Dec 24, 2021
@Dinistro
Copy link
Collaborator

Fixed by the mlir printing style

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants