dialects: (riscv) use helper for comment in label op #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
added
dialects
superlopuh
requested review from
AntonLydike,
nazavode,
math-fehr,
webmiche and
georgebisbas
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1020 +/- ##
=======================================
Coverage 86.81% 86.81%
=======================================
Files 125 125
Lines 19046 19041 -5
Branches 2885 2884 -1
=======================================
- Hits 16534 16530 -4
+ Misses 2012 2011 -1
Partials 500 500
☔ View full report in Codecov by Sentry. |
compor
approved these changes
May 29, 2023
| @@ -113,7 +113,7 @@ def test_label_op_with_comment(): | |||
| assert label_op.label.data == label_str | |||
|
|
|||
| code = riscv_code(ModuleOp([label_op])) | |||
| assert code == f"{label_str}: # my label\n" | |||
| assert code == f"{label_str}: # my label\n" | |||
There was a problem hiding this comment.
makes comments be aligned and a bit out of the way; it's just stylistic.
adutilleul
approved these changes
May 30, 2023
AntonLydike
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.