core: Correctly parse identifiers that start with a number [Minor]

[AntonLydike]

This change makes it so 2d-grid is tokenized to [IDENT(2d-grid)] instead of [NUMBER(2), IDENT(d-grid)]

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (62f0630) 87.00% compared to head (087105e) 87.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1023   +/-   ##
=======================================
  Coverage   87.00%   87.00%           
=======================================
  Files         125      125           
  Lines       19202    19197    -5     
  Branches     2915     2914    -1     
=======================================
- Hits        16706    16702    -4     
+ Misses       2000     1999    -1     
  Partials      496      496           

Impacted Files	Coverage Δ
tests/test_pass_lexer.py	100.00% <ø> (ø)
xdsl/utils/parse_pipeline.py	100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[webmiche]

This does not really generalize, right? So 13d-grid has still the same issue. This feels quite intuitive, would there be an easy fix?

[AntonLydike]

This does not really generalize, right? So 13d-grid has still the same issue. This feels quite intuitive, would there be an easy fix?

It does actually handle this! [0-9]+[A-Za-z_-]+[A-Za-z0-9_-]* matches one or more numbers, then at least one non-number character, and then any amount of "normal" ident characters.

[PapyChacal]

This does not really generalize, right? So 13d-grid has still the same issue. This feels quite intuitive, would there be an easy fix?

It does actually handle this! [0-9]+[A-Za-z_-]+[A-Za-z0-9_-]* matches one or more numbers, then at least one non-number character, and then any amount of "normal" ident characters.

Let's add tests then?

[math-fehr]

👍

[webmiche]

Okay, that's fine then 👍
Not used to python regex syntax 😅

[superlopuh]

Do you know what the MLIR regex is by any chance?

[AntonLydike]

Do you know what the MLIR regex is by any chance?

MLIR uses the llvm infrastructure, and that doesn't use regexes. It's a really convoluted system for them.