core: Add AffineMap #1029
core: Add AffineMap #1029
Conversation
Groverkss
requested review from
math-fehr,
webmiche and
georgebisbas
as code owners
Groverkss
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1029 +/- ##
==========================================
- Coverage 87.00% 86.69% -0.32%
==========================================
Files 125 132 +7
Lines 19197 20656 +1459
Branches 2914 3129 +215
==========================================
+ Hits 16702 17907 +1205
- Misses 1999 2235 +236
- Partials 496 514 +18
☔ View full report in Codecov by Sentry. |
tests/test_affine_builtins.py
Outdated
|
|
||
| # (5 * d0) + s0 + 1 | ||
| c = (a * 5) + b + 1 | ||
| print(c) |
There was a problem hiding this comment.
For testing here, I would assert that this is equal to AffineExpr constructed manually (without the operators).
xdsl/ir.py
Outdated
| SymbolId = ("s",) | ||
|
|
||
|
|
||
| class _AffineExprStorage(ABC): |
There was a problem hiding this comment.
Could you write a bit of documentation for each of these classes? Mostly to help us understand.
|
Super happy to see affine being added, thanks @Groverkss! You're doing the lords work! |
|
@Groverkss, this is a great addition. I am looking forward to seeing this upstreamed. This will really allow us to parse and use one of the most unconventional MLIR dialects, with this funny AffineExpr encoding. Cool! I would love to see this merged. |
xdsl/ir.py
Outdated
| Add = ("+",) | ||
| Mul = ("*",) | ||
| Mod = ("mod",) | ||
| FloorDiv = ("floordiv",) | ||
| CeilDiv = ("ceildiv",) | ||
| Constant = ("const",) | ||
| DimId = ("d",) | ||
| SymbolId = ("s",) |
There was a problem hiding this comment.
This can certainly be done better.
This patch adds AffineMap to core ir. AffineMap allows modeling many dialects in upstream MLIR like Linalg, Affine, Memref (load/store), SCF, etc.
This patch adds AffineMap to core ir. AffineMap allows modeling many dialects in upstream MLIR like Linalg, Affine, Memref (load/store), SCF, etc.