Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transformations: Add a flag for target selection on stencil conversion. #1031

Merged
merged 2 commits into from May 31, 2023
Merged

transformations: Add a flag for target selection on stencil conversion. #1031

merged 2 commits into from May 31, 2023

Conversation

PapyChacal
Copy link
Collaborator

Get rid of convert-stencil-to-gpu as it can be a simple flag now.
Use a Literal flag type to enforce specific values only.
Add tests for that case.
Stacked on #1030

@PapyChacal PapyChacal added the transformations Changes or adds a transformatio label May 30, 2023
@PapyChacal PapyChacal self-assigned this May 30, 2023
@PapyChacal PapyChacal mentioned this pull request May 30, 2023
Merged
@PapyChacal PapyChacal added the minor For minor PRs, easy and quick to review, quickly mergeable label May 30, 2023
Base automatically changed from emilien/isa-literal to main May 30, 2023 19:15
webmiche
webmiche approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@webmiche webmiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pressed the update branch button, that seems to have merged main into this branch. I hope I did not break anything, @PapyChacal. Might be a dumb idea to do that as a non-author, so sorry 😅

Other than that, LGTM.

@webmiche
Copy link
Collaborator

Okay, I definitely broke something, whups!

@webmiche
Copy link
Collaborator

Can you force push your local branch before pulling? Or do the merge locally and then force push...

georgebisbas
georgebisbas reviewed May 31, 2023
View reviewed changes
Copy link
Contributor

@georgebisbas georgebisbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, I guess you need to fix/update first

@webmiche webmiche changed the title transofrmations: Add a flag for target selection on stencil conversion. transformations: Add a flag for target selection on stencil conversion. May 31, 2023
@PapyChacal
Copy link
Collaborator Author

I pressed the update branch button, that seems to have merged main into this branch. I hope I did not break anything, @PapyChacal. Might be a dumb idea to do that as a non-author, so sorry 😅

Other than that, LGTM.

Thanks for offering to take the blame, but I did something wrong before you 😛
The auto-rebase on the base branch merged failed and included the base branch commits, and I still wanted to call it a day
I'll clean that today!

@PapyChacal PapyChacal force-pushed the emilien/stencil-conversion-flag branch from d7ae3fe to 0d4521d Compare May 31, 2023 13:52
@PapyChacal PapyChacal merged commit 671d571 into main May 31, 2023
11 checks passed
@PapyChacal PapyChacal deleted the emilien/stencil-conversion-flag branch May 31, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgebisbas georgebisbas georgebisbas left review comments

@superlopuh superlopuh superlopuh approved these changes

@webmiche webmiche webmiche approved these changes

@meshtag meshtag meshtag approved these changes

@math-fehr math-fehr Awaiting requested review from math-fehr

Assignees

@PapyChacal PapyChacal

Labels
minor For minor PRs, easy and quick to review, quickly mergeable transformations Changes or adds a transformatio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PapyChacal @webmiche @superlopuh @georgebisbas @meshtag