dialects: (func) add init to func.FuncOp #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
tobiasgrosser,
AntonLydike,
math-fehr,
JosseVanDelm,
PapyChacal and
webmiche
superlopuh
changed the title
superlopuh
added
dialects
math-fehr
approved these changes
May 31, 2023
webmiche
approved these changes
May 31, 2023
| function_type=(input_types, return_types), | ||
| region=Region(), | ||
| visibility="private", | ||
| ) | ||
|
|
||
| @staticmethod | ||
| def from_region( |
There was a problem hiding this comment.
Maybe deprecate/remove this?
There was a problem hiding this comment.
Good idea, although I think that can be an issue for the time being: #1038
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1037 +/- ##
=======================================
Coverage 86.89% 86.90%
=======================================
Files 125 125
Lines 19319 19324 +5
Branches 2929 2929
=======================================
+ Hits 16788 16794 +6
+ Misses 2029 2028 -1
Partials 502 502
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.