testing: Merge and simplify convert-stencil-to-ll-mlir filechecks. #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PapyChacal
requested review from
math-fehr,
webmiche and
georgebisbas
as code owners
PapyChacal
force-pushed
the
emilien/stencil-filecheck-conversion
branch
from
1f5b6fb
to
077513c
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## emilien/stencil-filecheck-polish #1046 +/- ##
====================================================================
- Coverage 86.95% 86.92% -0.04%
====================================================================
Files 126 126
Lines 19434 19434
Branches 2948 2948
====================================================================
- Hits 16899 16893 -6
- Misses 2036 2041 +5
- Partials 499 500 +1 ☔ View full report in Codecov by Sentry. |
|
I'll add some examples to get the coverage at least back to before the PR (for the stencil code; don't know about those parser internal corner-cases!) |
PapyChacal
force-pushed
the
emilien/stencil-filecheck-conversion
branch
from
077513c
to
ff6249a
Compare
|
Stacked on #1047 because part of the coverage loss is due to an issue with the shape inference's filecheck. |
georgebisbas
approved these changes
May 31, 2023
Some were just removed, e.g. separate load/cast/access tests, which are just tested in every example.
Thos can be thought of as reconciled unrealized casts.
PapyChacal
force-pushed
the
emilien/stencil-filecheck-conversion
branch
from
0ad9e64
to
7a03f56
Compare
|
At time of writing the Codecov comment takes time to update but I checked codecov report for the loss of coverage and it's alright now (https://app.codecov.io/gh/xdslproject/xdsl/pull/1046) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some were just removed, e.g. separate load/cast/access tests, which are just tested in every example.
More importantly, this switches all examples to lowering-only of shape infered examples, to separately test shape-inference and conversion from now on.