dialects: (memref) Make alignment for memref.alloc optional #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1052 +/- ##
=======================================
Coverage 87.09% 87.09%
=======================================
Files 127 127
Lines 19612 19612
Branches 2971 2971
=======================================
Hits 17082 17082
Misses 2023 2023
Partials 507 507
☔ View full report in Codecov by Sentry. |
PapyChacal
approved these changes
Jun 1, 2023
|
Yep, there is! |
georgebisbas
approved these changes
Jun 1, 2023
| shape: Optional[Iterable[int | AnyIntegerAttr]] = None, | ||
| ) -> Alloc: | ||
| if shape is None: | ||
| shape = [1] | ||
| return Alloc.build( | ||
| operands=[[], []], | ||
| result_types=[MemRefType.from_element_type_and_shape(return_type, shape)], | ||
| attributes={"alignment": IntegerAttr.from_int_and_width(alignment, 64)}, | ||
| attributes={ |
There was a problem hiding this comment.
nitpicking: I think it would be more readable with if outside?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to also be the case for mlir, so we don't actually need it