transformations: Split ApplyOp and AccessOp shape inference patterns. #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PapyChacal
requested review from
math-fehr,
webmiche and
georgebisbas
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1054 +/- ##
==========================================
+ Coverage 86.92% 86.95% +0.03%
==========================================
Files 129 129
Lines 19703 19713 +10
Branches 2981 2979 -2
==========================================
+ Hits 17126 17141 +15
+ Misses 2070 2068 -2
+ Partials 507 504 -3
☔ View full report in Codecov by Sentry. |
…dle different input offsets. Add a test case for this. Now, shape inference walk ops regions first; each accessop offset it's stencil.temp operand size individually. stencil.apply shape inference then just spreads these bounds to its operands (from its block arguments).
PapyChacal
force-pushed
the
emilien/stencil-inference-split
branch
from
ccd926a
to
d50c090
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To naturally handle different input offsets.
Add a test case for this.
Now, shape inference walk ops regions first; each stencil.access offset it's stencil.temp operand size individually. stencil.apply shape inference then just spreads these bounds to its operands (from its block arguments).