dialects: (dmp) A bunch of fixes in the lowering #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonLydike
requested review from
math-fehr,
webmiche and
georgebisbas
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1061 +/- ##
==========================================
- Coverage 86.92% 86.90% -0.02%
==========================================
Files 129 130 +1
Lines 19703 20452 +749
Branches 2981 3112 +131
==========================================
+ Hits 17126 17774 +648
- Misses 2070 2169 +99
- Partials 507 509 +2
☔ View full report in Codecov by Sentry. |
superlopuh
reviewed
Jun 2, 2023
| @@ -211,7 +214,7 @@ def _emit_memref_counts( | |||
| if not all(dim.value.data >= 0 for dim in ssa_val.typ.shape.data): | |||
| raise RuntimeError("MPI lowering does not support unknown-size memrefs!") | |||
|
|
|||
| size = sum(dim.value.data for dim in ssa_val.typ.shape.data) | |||
| size = prod(dim.value.data for dim in ssa_val.typ.shape.data) | |||
There was a problem hiding this comment.
seems like a useful helper to add on the type, potentially?
superlopuh
reviewed
Jun 2, 2023
| cst0 = arith.Constant.from_int_and_width(0, idx) | ||
| cst1 = arith.Constant.from_int_and_width(1, idx) | ||
|
|
||
| @Builder.implicit_region([idx, idx]) |
There was a problem hiding this comment.
It's so wonderful to use! Thanks for adding it!
superlopuh
approved these changes
Jun 2, 2023
georgebisbas
approved these changes
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.