Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Move type parsing to lexer (NFC) #1068

Merged
merged 2 commits into from Jun 5, 2023

Conversation

math-fehr
Copy link
Collaborator

This moves the parsing of types to the lexer, from the tokenizer.
It does not change any functionality.

@math-fehr math-fehr added the core xDSL core (ir, textual format, ...) label Jun 4, 2023
@math-fehr math-fehr requested a review from webmiche as a code owner June 4, 2023 13:23
@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@c744c8c). Click here to learn what that means.
Patch coverage: 96.05% of modified lines in pull request are covered.

❗ Current head ee42088 differs from pull request most recent head 47eaa60. Consider uploading reports for the commit 47eaa60 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1068   +/-   ##
=======================================
  Coverage        ?   86.79%           
=======================================
  Files           ?      130           
  Lines           ?    20442           
  Branches        ?     3098           
=======================================
  Hits            ?    17742           
  Misses          ?     2190           
  Partials        ?      510           
Impacted Files Coverage Δ
xdsl/parser.py 85.34% <95.71%> (ø)
xdsl/dialects/func.py 95.75% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@math-fehr math-fehr merged commit 88816f6 into main Jun 5, 2023
11 checks passed
@math-fehr math-fehr deleted the fehr/move-type-parsing-to-lexer branch June 5, 2023 09:18
cigarichard pushed a commit to cigarichard/xdsl that referenced this pull request Jun 17, 2023
This moves the parsing of types to the lexer, from the tokenizer.
It does not change any functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants