docs: (toy) optional instead of error in parser #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1070 +/- ##
==========================================
- Coverage 86.93% 86.79% -0.14%
==========================================
Files 129 130 +1
Lines 19788 20423 +635
Branches 3017 3097 +80
==========================================
+ Hits 17202 17727 +525
- Misses 2077 2184 +107
- Partials 509 512 +3
☔ View full report in Codecov by Sentry. |
cigarichard
pushed a commit
to cigarichard/xdsl
that referenced
this pull request
Jun 17, 2023
Just a small change to help me debug, only throw errors if something has gone wrong, bool/optional otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small change to help me debug, only throw errors if something has gone wrong, bool/optional otherwise.