Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: move identifier parsing to lexer #1072

Merged
merged 6 commits into from Jun 5, 2023
Merged

Conversation

math-fehr
Copy link
Collaborator

No description provided.

@math-fehr math-fehr added the core xDSL core (ir, textual format, ...) label Jun 4, 2023
@math-fehr math-fehr changed the base branch from main to fehr/move-attr-parsing-to-lexer June 4, 2023 17:24
@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Patch coverage: 92.74% and project coverage change: -0.11 ⚠️

Comparison is base (59a2b58) 86.81% compared to head (0e7a6cb) 86.71%.

❗ Current head 0e7a6cb differs from pull request most recent head 6242a45. Consider uploading reports for the commit 6242a45 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1072      +/-   ##
==========================================
- Coverage   86.81%   86.71%   -0.11%     
==========================================
  Files         130      130              
  Lines       20399    20417      +18     
  Branches     3085     3092       +7     
==========================================
- Hits        17709    17704       -5     
- Misses       2182     2204      +22     
- Partials      508      509       +1     
Impacted Files Coverage Δ
xdsl/dialects/builtin.py 82.95% <50.00%> (-0.96%) ⬇️
xdsl/parser.py 84.92% <93.63%> (-0.65%) ⬇️
tests/test_parser.py 100.00% <100.00%> (ø)
xdsl/dialects/func.py 95.75% <100.00%> (ø)
xdsl/dialects/riscv.py 84.74% <100.00%> (-0.03%) ⬇️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@math-fehr math-fehr force-pushed the fehr/move-attr-parsing-to-lexer branch from 3a185bc to 3674b6c Compare June 5, 2023 09:20
Base automatically changed from fehr/move-attr-parsing-to-lexer to main June 5, 2023 09:24
@math-fehr math-fehr merged commit 93bf119 into main Jun 5, 2023
11 checks passed
@math-fehr math-fehr deleted the fehr/move-parse-bare-id branch June 5, 2023 09:28
cigarichard pushed a commit to cigarichard/xdsl that referenced this pull request Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants