New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: move identifier parsing to lexer #1072
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
math-fehr
requested review from
AntonLydike,
superlopuh,
compor,
nazavode,
webmiche and
georgebisbas
as code owners
June 4, 2023 17:24
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1072 +/- ##
==========================================
- Coverage 86.81% 86.71% -0.11%
==========================================
Files 130 130
Lines 20399 20417 +18
Branches 3085 3092 +7
==========================================
- Hits 17709 17704 -5
- Misses 2182 2204 +22
- Partials 508 509 +1
☔ View full report in Codecov by Sentry. |
superlopuh
approved these changes
Jun 4, 2023
georgebisbas
approved these changes
Jun 5, 2023
math-fehr
force-pushed
the
fehr/move-attr-parsing-to-lexer
branch
from
June 5, 2023 09:20
3a185bc
to
3674b6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.