core: Remove last uses of the tokenizer #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
math-fehr
requested review from
PapyChacal,
webmiche and
georgebisbas
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1073 +/- ##
==========================================
- Coverage 86.85% 86.75% -0.11%
==========================================
Files 130 130
Lines 20474 20470 -4
Branches 3095 3098 +3
==========================================
- Hits 17783 17758 -25
- Misses 2182 2204 +22
+ Partials 509 508 -1
☔ View full report in Codecov by Sentry. |
superlopuh
reviewed
Jun 4, 2023
superlopuh
approved these changes
Jun 4, 2023
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
math-fehr
force-pushed
the
fehr/parse-characters
branch
from
c325ed3
to
21aca15
Compare
AntonLydike
approved these changes
Jun 5, 2023
| @@ -71,37 +71,31 @@ class _GPUAttr(ParametrizedAttribute, Generic[T]): | |||
| def parse_parameters(parser: Parser) -> list[Attribute]: | |||
| parser.parse_characters( | |||
| "<", | |||
| f"Expected <. gpu attributes currently have the #gpu<name value> syntax.", | |||
| ": gpu attributes currently have the #gpu<name value> syntax.", | |||
There was a problem hiding this comment.
Why is the colon necessary here? Shouldn't that be added on the other side of the string format?
There was a problem hiding this comment.
I guess it's a style choice we can change.
Currently, parser methods with a context_msg option are printed like this: "error-msg" + context_msg, like in MLIR.
So, we can have error messages like '<' expected in attribute parameters for instance, making it a bit more concise and readable I think.
cigarichard
pushed a commit
to cigarichard/xdsl
that referenced
this pull request
Jun 17, 2023
This removes `parse_char`, which can use `parse_characters` instead. `parse_characters` now use a similar error naming scheme than the other methods. --------- Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
parse_char, which can useparse_charactersinstead.parse_charactersnow use a similar error naming scheme than the other methods.