Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: don't fail if can't run riscemu #1099

Merged
merged 2 commits into from Jun 8, 2023
Merged

Conversation

superlopuh
Copy link
Member

No description provided.

@superlopuh superlopuh added the testing PRs that modify tests label Jun 8, 2023
@superlopuh superlopuh self-assigned this Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (9bc2c33) 86.91% compared to head (1c83f19) 86.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1099      +/-   ##
==========================================
- Coverage   86.91%   86.89%   -0.02%     
==========================================
  Files         137      137              
  Lines       20576    20591      +15     
  Branches     3109     3110       +1     
==========================================
+ Hits        17883    17893      +10     
- Misses       2178     2182       +4     
- Partials      515      516       +1     
Impacted Files Coverage Δ
tests/interpreters/test_riscv_emulator.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@tobiasgrosser tobiasgrosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works for me. Maybe mention why you did not choose to use "REQUIRES:".

@superlopuh
Copy link
Member Author

To be honest I didn't find documentation on how to use it, so I just copied over what we have for the mlir interop tests

@compor compor self-requested a review June 8, 2023 08:30
@compor
Copy link
Collaborator

compor commented Jun 8, 2023

To be honest I didn't find documentation on how to use it, so I just copied over what we have for the mlir interop tests

https://www.llvm.org/docs/TestingGuide.html#constraining-test-execution

@superlopuh superlopuh merged commit 1c22562 into main Jun 8, 2023
12 checks passed
@superlopuh superlopuh deleted the sasha/riscemu-guard branch June 8, 2023 09:36
cigarichard pushed a commit to cigarichard/xdsl that referenced this pull request Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing PRs that modify tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants