Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Move backend related files to separate directories #1104

Merged
merged 5 commits into from Jun 12, 2023

Conversation

compor
Copy link
Collaborator

@compor compor commented Jun 8, 2023

This PR moves the current RISCV backend files (i.e., currently just register allocation strategies) to a directory under xdsl/backend/riscv/ to improve module organization.

@compor compor added the core xDSL core (ir, textual format, ...) label Jun 8, 2023
@compor compor self-assigned this Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 93.33% and project coverage change: -0.01 ⚠️

Comparison is base (833c9a1) 86.90% compared to head (f908a9d) 86.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1104      +/-   ##
==========================================
- Coverage   86.90%   86.90%   -0.01%     
==========================================
  Files         138      139       +1     
  Lines       20600    20597       -3     
  Branches     3117     3117              
==========================================
- Hits        17903    17900       -3     
  Misses       2180     2180              
  Partials      517      517              
Impacted Files Coverage Δ
xdsl/backend/riscv/register_allocation.py 92.85% <92.85%> (ø)
tests/backend/riscv/test_regalloc.py 100.00% <100.00%> (ø)
xdsl/transforms/riscv_register_allocation.py 100.00% <100.00%> (+5.55%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

docs/Toy/toy/tests/test_regalloc.py Outdated Show resolved Hide resolved
@tobiasgrosser
Copy link
Contributor

I think this is a great idea.

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@compor
Copy link
Collaborator Author

compor commented Jun 9, 2023

@AntonLydike @nazavode?

@compor compor changed the title core: Move backend related files to separate directory core: Move backend related files to separate directories Jun 9, 2023
@compor compor merged commit 41415aa into main Jun 12, 2023
12 checks passed
@compor compor deleted the christos/riscv/backend-dir-structure branch June 12, 2023 10:58
cigarichard pushed a commit to cigarichard/xdsl that referenced this pull request Jun 17, 2023
…#1104)

This PR moves the current RISCV backend files to a directory under `xdsl/backend/riscv/` to improve module organization and does the same for related test files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants