New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: Move backend related files to separate directories #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compor
requested review from
superlopuh,
nazavode,
AntonLydike,
JosseVanDelm and
adutilleul
June 8, 2023 16:09
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1104 +/- ##
==========================================
- Coverage 86.90% 86.90% -0.01%
==========================================
Files 138 139 +1
Lines 20600 20597 -3
Branches 3117 3117
==========================================
- Hits 17903 17900 -3
Misses 2180 2180
Partials 517 517
☔ View full report in Codecov by Sentry. |
superlopuh
requested changes
Jun 8, 2023
I think this is a great idea. |
superlopuh
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty
compor
changed the title
core: Move backend related files to separate directory
core: Move backend related files to separate directories
Jun 9, 2023
adutilleul
approved these changes
Jun 12, 2023
AntonLydike
approved these changes
Jun 12, 2023
cigarichard
pushed a commit
to cigarichard/xdsl
that referenced
this pull request
Jun 17, 2023
…#1104) This PR moves the current RISCV backend files to a directory under `xdsl/backend/riscv/` to improve module organization and does the same for related test files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the current RISCV backend files (i.e., currently just register allocation strategies) to a directory under
xdsl/backend/riscv/
to improve module organization.