Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: Add stencil-storage-materialization and first tests. #1111

Merged
merged 8 commits into from Jun 14, 2023

Conversation

PapyChacal
Copy link
Collaborator

Add the stencil-storage-materialization pass first implementation.

The idea is to add stencil.buffer on temporary values used and not otherwise mapped to storage.
This allows to lower chains of apply which are just chained by direct usage of another's result; can be a nice baseline to compare inlining to.

@PapyChacal PapyChacal added the transformations Changes or adds a transformatio label Jun 9, 2023
@PapyChacal PapyChacal self-assigned this Jun 9, 2023
@PapyChacal PapyChacal changed the title transofrmations: Add stencil-storage-materialization and first tests. transformations: Add stencil-storage-materialization and first tests. Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (fdbe68a) 87.31% compared to head (3c38a4a) 87.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
+ Coverage   87.31%   87.36%   +0.05%     
==========================================
  Files         142      143       +1     
  Lines       21084    21114      +30     
  Branches     3174     3178       +4     
==========================================
+ Hits        18409    18447      +38     
+ Misses       2169     2163       -6     
+ Partials      506      504       -2     
Impacted Files Coverage Δ
xdsl/dialects/stencil.py 97.71% <100.00%> (+0.02%) ⬆️
...orms/experimental/StencilStorageMaterialization.py 100.00% <100.00%> (ø)
xdsl/xdsl_opt_main.py 96.60% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@AntonLydike AntonLydike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Just some minor nitpicks on my side, otherwise this looks really good!

@PapyChacal PapyChacal merged commit 83fedee into main Jun 14, 2023
12 checks passed
@PapyChacal PapyChacal deleted the emilien/stencil-materialize branch June 14, 2023 14:48
cigarichard pushed a commit to cigarichard/xdsl that referenced this pull request Jun 17, 2023
…xdslproject#1111)

Add the stencil-storage-materialization pass first implementation.

The idea is to add `stencil.buffer` on temporary values used and not
otherwise mapped to storage.
This allows to lower chains of apply which are just chained by direct
usage of another's result; can be a nice baseline to compare inlining
to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants