New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transformations: Add stencil-storage-materialization and first tests. #1111
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1111 +/- ##
==========================================
+ Coverage 87.31% 87.36% +0.05%
==========================================
Files 142 143 +1
Lines 21084 21114 +30
Branches 3174 3178 +4
==========================================
+ Hits 18409 18447 +38
+ Misses 2169 2163 -6
+ Partials 506 504 -2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Just some minor nitpicks on my side, otherwise this looks really good!
tests/filecheck/transforms/stencil-storage-materialization.mlir
Outdated
Show resolved
Hide resolved
…xdslproject#1111) Add the stencil-storage-materialization pass first implementation. The idea is to add `stencil.buffer` on temporary values used and not otherwise mapped to storage. This allows to lower chains of apply which are just chained by direct usage of another's result; can be a nice baseline to compare inlining to.
Add the stencil-storage-materialization pass first implementation.
The idea is to add
stencil.buffer
on temporary values used and not otherwise mapped to storage.This allows to lower chains of apply which are just chained by direct usage of another's result; can be a nice baseline to compare inlining to.