core: Implement and use IsolatedFromAbove #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure leveraging it)
Also add missing decorators on RISCV ops. The new IsolatedFromAbove verifier triggered errors on those operations otherwise.
PapyChacal
requested review from
AntonLydike,
meshtag,
superlopuh,
compor,
nazavode,
math-fehr,
webmiche and
georgebisbas
as code owners
|
I wasn't sure about |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1122 +/- ##
==========================================
+ Coverage 87.01% 87.07% +0.05%
==========================================
Files 139 139
Lines 20914 20964 +50
Branches 3146 3163 +17
==========================================
+ Hits 18199 18254 +55
+ Misses 2193 2191 -2
+ Partials 522 519 -3
☔ View full report in Codecov by Sentry. |
AntonLydike
approved these changes
Jun 12, 2023
superlopuh
reviewed
Jun 12, 2023
superlopuh
reviewed
Jun 12, 2023
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
|
@compor Added a nested test. Does it look like what you had in mind? 🙂 |
compor
approved these changes
Jun 12, 2023
cigarichard
pushed a commit
to cigarichard/xdsl
that referenced
this pull request
Jun 17, 2023
Implements IsolatedFromAbove and use it on existing MLIR operations that are supposed to. MLIR's implementation: https://mlir.llvm.org/doxygen/IR_2Operation_8cpp_source.html#l01231 --------- Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements IsolatedFromAbove and use it on existing MLIR operations that are supposed to.
MLIR's implementation: https://mlir.llvm.org/doxygen/IR_2Operation_8cpp_source.html#l01231