core: Remove runtime type check in Data

[math-fehr]

Previously, Data was expecting a verify method whenever the Data type parameter was not a class.
This is now removed, as we trust the user to respect the types.

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (ef4b54d) 87.21% compared to head (ef4be8d) 87.24%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1126      +/-   ##
==========================================
+ Coverage   87.21%   87.24%   +0.02%     
==========================================
  Files         142      142              
  Lines       21034    20997      -37     
  Branches     3169     3161       -8     
==========================================
- Hits        18345    18318      -27     
+ Misses       2177     2172       -5     
+ Partials      512      507       -5     

Impacted Files	Coverage Δ
tests/test_attribute_definition.py	95.48% <ø> (-0.12%)	⬇️
xdsl/dialects/builtin.py	83.61% <100.00%> (ø)
xdsl/irdl.py	92.04% <100.00%> (+0.96%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[AntonLydike]

Notably, this made it impossible to have things like Data[tuple[int,...]], as PyRDL did not understand these constraints, but pyright would complain when the encapsulating type was left out (e.g. Data[tuple]).

[math-fehr]

Notably, this made it impossible to have things like Data[tuple[int,...]], as PyRDL did not understand these constraints, but pyright would complain when the encapsulating type was left out (e.g. Data[tuple]).

Actually, it was possible, you just needed to define verify. But that was an unnecessary and dumb restriction.