dialects: (dmp) Fix dmp-to-mpi lowering to work for n-d #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonLydike
requested review from
math-fehr,
webmiche and
georgebisbas
as code owners
AntonLydike
force-pushed
the
anton/dmp-2d-grid
branch
from
46dd988
to
0971f34
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1132 +/- ##
==========================================
- Coverage 87.26% 87.10% -0.17%
==========================================
Files 142 142
Lines 21026 21072 +46
Branches 3164 3171 +7
==========================================
+ Hits 18349 18355 +6
- Misses 2170 2210 +40
Partials 507 507
☔ View full report in Codecov by Sentry. |
Comment on lines
+53
to
+56
| grid_tuple = grid.as_tuple() | ||
| if len(grid_tuple) == 1: | ||
| grid_tuple = (grid_tuple[0], 1) | ||
| assert len(grid_tuple) == 2 |
There was a problem hiding this comment.
This looks weird? What is so special about grid ?
There was a problem hiding this comment.
This just makes the below code work for the horizontal and grid slicing
cigarichard
pushed a commit
to cigarichard/xdsl
that referenced
this pull request
Jun 17, 2023
…1132) This patch generalizes the mpi rank calcualtions from 1d to nd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch generalizes the mpi rank calcualtions from 1d to nd.