transformations: Use subviews and memcopy in stencil distribution pass. #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PapyChacal
requested review from
math-fehr,
webmiche and
georgebisbas
as code owners
PapyChacal
added
the
minor
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1159 +/- ##
==========================================
+ Coverage 88.45% 88.55% +0.10%
==========================================
Files 156 156
Lines 22000 21974 -26
Branches 3301 3302 +1
==========================================
- Hits 19460 19459 -1
+ Misses 2009 1984 -25
Partials 531 531
☔ View full report in Codecov by Sentry. |
georgebisbas
approved these changes
Jun 19, 2023
PapyChacal
force-pushed
the
emilien/dmp-subview
branch
from
0c0ed5a
to
025a5e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #1158
The initial lowering is generating full-blown loop-nests to copy the data to temporary buffers, and is restricted to 2D for sanity.
Using the meanwhile implemented subview constructor and memcopy op, make it relatively trivial, generic, and probably more efficient 🤔 Last point left as an exercise..
Oh, right: also checked for correctness on a 4x4 grid decomposition! The results seemed exactly the same to the bit.