Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (dmp)A bunch of changes that came up when integrating xDSL directly into devito. #1160

Merged
merged 28 commits into from Jul 14, 2023

Conversation

AntonLydike
Copy link
Collaborator

Note: this will break the current benchmarking setup for devito.

@AntonLydike AntonLydike added the dialects Changes on the dialects label Jun 19, 2023
@AntonLydike AntonLydike self-assigned this Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 38.88% and project coverage change: +0.20 🎉

Comparison is base (2423d28) 89.12% compared to head (3b92ddf) 89.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1160      +/-   ##
==========================================
+ Coverage   89.12%   89.32%   +0.20%     
==========================================
  Files         181      180       -1     
  Lines       24073    24000      -73     
  Branches     3667     3652      -15     
==========================================
- Hits        21455    21439      -16     
+ Misses       2040     1989      -51     
+ Partials      578      572       -6     
Impacted Files Coverage Δ
xdsl/dialects/experimental/dmp.py 50.24% <ø> (ø)
xdsl/transforms/experimental/dmp/decompositions.py 53.70% <0.00%> (-3.16%) ⬇️
xdsl/xdsl_opt_main.py 96.69% <ø> (-0.02%) ⬇️
...sforms/experimental/dmp/stencil_global_to_local.py 26.59% <58.33%> (+0.62%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AntonLydike AntonLydike changed the title A bunch of changes that came up when integrating xDSL directly into devito. dialects: (dmp)A bunch of changes that came up when integrating xDSL directly into devito. Jun 19, 2023
@AntonLydike
Copy link
Collaborator Author

Merging will coincide with a PR on the devito PR so that we don't break benchmarking. Just FYI.

Copy link
Contributor

@georgebisbas georgebisbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely, thanks

@AntonLydike AntonLydike merged commit ea17fb4 into main Jul 14, 2023
10 checks passed
@AntonLydike AntonLydike deleted the anton/devito-integration branch July 14, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants